Change in vdsm[master]: Make sr-iov hook use interface instead of hostdev

danken at redhat.com danken at redhat.com
Thu Apr 4 21:00:47 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Make sr-iov hook use interface instead of hostdev
......................................................................


Patch Set 7: I would prefer that you didn't submit this

Toni, I am a bit worried about "After installing vdsm, libvirt loses the ability to attach devices/images that belong to root."

Could you give some information about the failure? Which of vdsm's configurations cause this? Is it "dynamic_ownership 0"?

writeSriovCache() is clearly a messy racy function, I'd like to kill it. But could you split this into a follow up patch? I mean, let's have a patch to make this work for a single VM started, and another patch making the whole thing reentrant.

--
To view, visit http://gerrit.ovirt.org/13541
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f88a8400fe4d230c0877428afef62df8e397db
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Yasny <dyasny at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list