Change in vdsm[master]: Make sr-iov hook use interface instead of hostdev

asegurap at redhat.com asegurap at redhat.com
Thu Apr 4 09:05:49 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: Make sr-iov hook use interface instead of hostdev
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm_hooks/sriov/before_vm_start.py
Line 141: 
Line 142:                 sys.stderr.write('sriov: VF %s xml: %s\n' %
Line 143:                                  (nic, interface.toxml()))
Line 144:                 devices.appendChild(interface)
Line 145:                 chown(devpath)
That's funny. I was just checking on my machine with virsh calls to attach and I didn't need the chown, so I put a comment here to check if it is really necessary. I uploaded a version that drops the sriovcache and drops the chown.
Line 146:                 writeSriovCache(nic, addr, devpath)
Line 147:             else:
Line 148:                 sys.stderr.write('sriov: cannot find nic "%s", aborting\n' %
Line 149:                                  nic)


--
To view, visit http://gerrit.ovirt.org/13541
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f88a8400fe4d230c0877428afef62df8e397db
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Yasny <dyasny at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list