Change in vdsm[master]: Make sr-iov hook use interface instead of hostdev

asegurap at redhat.com asegurap at redhat.com
Wed Apr 3 23:38:40 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: Make sr-iov hook use interface instead of hostdev
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm_hooks/sriov/after_vm_destroy.py
Line 34:             with open(path, 'r') as f:
Line 35:                 for line in f:
Line 36:                     nicAddr = line.split('=')
Line 37:                     if nicAddr[0] in nics:
Line 38:                         restoreDevicePermissions(nicAddr[1],
@Shu Ming: I checked and libvirtvm.py when doing hooks.after_vm_destroy ignores the returned xml. So no need to remove the SriovElement from the xml that is passed to the hook in this particular case (No other hook does it on destroy for the same reason, I presume).
Line 39:                                                  nicAddr[2].strip('\n'))
Line 40:                     else:
Line 41:                         lines += line
Line 42: 


--
To view, visit http://gerrit.ovirt.org/13541
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f88a8400fe4d230c0877428afef62df8e397db
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Yasny <dyasny at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list