Change in vdsm[master]: Prefetch domains when connecting a storage server.

abaron at redhat.com abaron at redhat.com
Wed Apr 3 20:20:51 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: Prefetch domains when connecting a storage server.
......................................................................


Patch Set 6: (1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 2307:                     "Could not connect to storageServer", exc_info=True)
Line 2308:                 status, _ = self._translateConnectionError(err)
Line 2309:             else:
Line 2310:                 status = 0
Line 2311:                 doms = self.__prefetchDomains(domType, conObj)
not because it's new code, because it has nothing to do with the connect logic/flow and shouldn't fail connect.
This is basically an optimization for domains purposes, but connect actually has nothing to do with domains (connect could be sent for direct lun or for other purposes as well).
Imagine a scenario where I connect for another purpose and then fail on prefetch (I don't care why) even though the connect has nothing to do with any domain.  That doesn't make sense.  In fact Eduardo agrees with me, he's just so against general exception catching that he can't bring himself to write the general try..except.
Also note that if prefetchDomains fails here (but ignored), behaviour remains exactly as it is today without this patch.
Line 2312:                 sdCache.knownSDs.update(doms)
Line 2313: 
Line 2314:             self.log.debug("knownSDs: %s", sdCache.knownSDs)
Line 2315: 


--
To view, visit http://gerrit.ovirt.org/12869
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f2b19a566c659bac30a318d17cef929e0b2575b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list