Change in vdsm[master]: Per device custom properties for before/after vm destroy.
danken at redhat.com
danken at redhat.com
Wed Apr 3 19:28:09 UTC 2013
Dan Kenigsberg has posted comments on this change.
Change subject: Per device custom properties for before/after vm destroy.
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 1294: leaseElem.appendChildWithArgs('target', path=leasePath,
Line 1295: offset=str(leaseOffset))
Line 1296: return leaseElem
Line 1297:
Line 1298: def _customDevices(self):
oh, so here's the generator!
Line 1299: """
Line 1300: Get all devices that have custom properties
Line 1301: """
Line 1302:
Line 1317:
Line 1318: for devType in self._devices:
Line 1319: for dev in self._devices[devType]:
Line 1320: if devType == vm.NIC_DEVICES:
Line 1321: dev.custom = {'qos': 3}
this looks like a private test, sneaking upstream.
Line 1322:
Line 1323: for dev in self._customDevices():
Line 1324: deviceXML = dev.getXML().toxml(encoding='utf-8')
Line 1325: deviceXML = hooks.before_device_create(
--
To view, visit http://gerrit.ovirt.org/13411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic18b838dc51ea6bde31ef1a4bf0d0d372d95cd41
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list