Change in vdsm[master]: Fix vdsm-reg service name

fgranha at linux.vnet.ibm.com fgranha at linux.vnet.ibm.com
Tue Sep 25 16:34:00 UTC 2012


Fernando Granha Jeronimo has posted comments on this change.

Change subject: Fix vdsm-reg service name
......................................................................


Patch Set 3:

Hello Ryan,

I totally agree, I will split this patch.

WRT the race condition, I think I have a different
understanding of the steps. Please, correct me if I am wrong.

1) node boot (firstboot=1, aka install)
2) vdsm-reg service starts. It keeps reading the configuration
   file checking if there is enough information to automatically register
   the node.
3) After all installation steps, if it succeeds, the scripts in the
   /etc/ovirt-config-boot.d will be automatically executed. It can
   can be something to prevent cobbler netboot to avoid an infinite
   installation loop. In our case, we have the vdsm-config script which
   is in charge of reading the kernel parameters and writing them to
   the vdsm-reg configuration file. All these hook scripts, are
   executed just before the node is rebooted.
4) If just before reboot, the vdsm-reg sees that it has enough information
   in the configuration file to register the node, it will attempt the
   registration process. Once this process is not atomic, we could possibly
   reach an inconsistent state. It is safer to only register the node
   after reboot, when we will have plenty of time for that.

Once this problem only happens when the hook script vdsm-config is executed,
it is IMO cleaner to just stop the service in that precise point, letting the
vdsm-reg service enabled in all other cases.

--
To view, visit http://gerrit.ovirt.org/8037
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id96224cd61e6cd1e88ca94649b71f2f5f88886c1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fernando Granha Jeronimo <fgranha at linux.vnet.ibm.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Fernando Granha Jeronimo <fgranha at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>


More information about the vdsm-patches mailing list