Change in vdsm[master]: Fix some pep8 errors

danken at redhat.com danken at redhat.com
Sun Sep 30 08:11:07 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Fix some pep8 errors
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

Zhou, misc.py is already in the whitelist.

....................................................
File vdsm/storage/misc.py
Line 643:         currentThread = threading.currentThread()
Line 644: 
Line 645:         # Handle reacquiring lock in the same thread
Line 646:         if currentThread in self._holdingThreads:
Line 647:             if not self._currentState and exclusive:
as noted earlier by ShaoHe Feng, this is a logic change, not only a stylistic one.

even if you really want to mix the two in the same patch, his comment deserve an explanation.
Line 648:                 raise RuntimeError("Lock promotion is forbidden.")
Line 649: 
Line 650:             self._holdingThreads[currentThread] += 1
Line 651:             return


--
To view, visit http://gerrit.ovirt.org/8237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I417f646b8fc1f242f3d5c91fdf0d7e79600552e9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list