Change in vdsm[master]: vdsm: Use virsh to check if libvirt is up

masayag at redhat.com masayag at redhat.com
Thu Sep 27 15:38:49 UTC 2012


Moti Asayag has posted comments on this change.

Change subject: vdsm: Use virsh to check if libvirt is up
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/vdsmd.init.in
Line 401:     # this workaround should be removed.
Line 402: 
Line 403:     for i in {1..50}
Line 404:     do
Line 405:         if virsh -r version > /dev/null 2>&1 &&
I don't mind adding python module to perform it. Please note that libvirtconnection.py cannot be invoked by 'python libvirtconnection.py' due to 

Traceback (most recent call last):
  File "libvirtconnection.py", line 27, in <module>
    import libvirtev
ImportError: No module named libvirtev

Therefore it will have to be a new module to reside somewhere under /usr/share/vdsm
Line 406:                 pgrep libvirtd > /dev/null 2>&1; then
Line 407:             return 0
Line 408:         fi
Line 409:         sleep 0.2


--
To view, visit http://gerrit.ovirt.org/8245
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2844070ca0816525851b3b495b3dfe3096058a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list