Change in vdsm[master]: avoid creating hangover in storage domain cache after format...

abaron at redhat.com abaron at redhat.com
Wed Sep 26 23:16:00 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: avoid creating hangover in storage domain cache after formatting
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 2197:             try:
Line 2198:                 sdCache.manuallyRemoveDomain(dom.sdUUID)
Line 2199:             except KeyError:
Line 2200:                 self.log.warn("Storage domain %s doesn't exist in cache. "
Line 2201:                               "Trying recycle leftovers ...", dom.sdUUID)
is 'dom' still a valid object at this point? it would seem to me that you need to save sdUUID before removing the domain from the cache and then use that here and not access dom.sdUUID
Line 2202: 
Line 2203: 
Line 2204:     @public
Line 2205:     def formatStorageDomain(self, sdUUID, autoDetach = False, options = None):


--
To view, visit http://gerrit.ovirt.org/8144
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie13a97ad6830553cbd099189dfb82d6f02ce82fe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list