Change in vdsm[master]: schema: make ConnectionRefArgs definition agree with the cod...

agl at us.ibm.com agl at us.ibm.com
Wed Sep 26 13:29:06 UTC 2012


Adam Litke has posted comments on this change.

Change subject: schema: make ConnectionRefArgs definition agree with the code
......................................................................


Patch Set 3: I would prefer that you didn't submit this

'type' is not a valid identifier for a gobject-based library because it causes naming conflicts with the GType system.  In order to solve the problem you have identified, we must convert the 'connType' member to 'type' at the last minute just before passing the args into vdsm.  This will be done by some translation code inside Bridge.py.

--
To view, visit http://gerrit.ovirt.org/8020
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb209b577c6736b3b50cf400996b0999a60a8776
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list