Change in vdsm[master]: dump the core of a domain

shaohef at linux.vnet.ibm.com shaohef at linux.vnet.ibm.com
Wed Sep 26 08:17:48 UTC 2012


ShaoHe Feng has posted comments on this change.

Change subject: dump the core of a domain
......................................................................


Patch Set 4: (2 inline comments)

....................................................
Commit Message
Line 3: AuthorDate: 2012-08-07 17:04:58 +0800
Line 4: Commit:     ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Line 5: CommitDate: 2012-09-24 19:58:06 +0800
Line 6: 
Line 7: dump the core of a domain
yes, VM is clear than domain
Line 8: 
Line 9: libvirt support an API to dump the core of a domain on a given file for
Line 10: analysis when guest OS crash.
Line 11: 


....................................................
File vdsm/vm.py
Line 303: 
Line 304:     def _finishSuccessfully(self):
Line 305:         self.status = {'status': {'code': 0, 'message':
Line 306:                                   'Dump finished sucessfully'},
Line 307:                        'progress': "done"}
surely, it can, so does it need a lock?  only in the  worker thread can write the self.status, so I use _coreDumpOngoingEvt indicate when to read self.status for main thread.
Line 308: 
Line 309:     def run(self):
Line 310: 
Line 311:         def reportError(key='coreDumpErr', msg=None):


--
To view, visit http://gerrit.ovirt.org/7329
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4aac9e747dc7aa64a6ff5ef256a7a4375aa2bb5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list