Change in vdsm[master]: Fix onDomainConnectivityStateChange in DomainMonitorThread

smizrahi at redhat.com smizrahi at redhat.com
Tue Sep 25 10:32:58 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: Fix onDomainConnectivityStateChange in DomainMonitorThread
......................................................................


Patch Set 4: I would prefer that you didn't submit this

I don't understand why that fixes. And I don't understand why you didn't also add DomainMonitorStrings class to put all the string fields of domain monitor in it

--
To view, visit http://gerrit.ovirt.org/7772
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3b7e7c788b54726a3c820f4f2180884c74d93ef
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list