Change in vdsm[master]: [WIP] BZ#855922, fix attribute error during migration

peet at redhat.com peet at redhat.com
Tue Sep 25 07:11:49 UTC 2012


Peter V. Saveliev has uploaded a new change for review.

Change subject: [WIP] BZ#855922, fix attribute error during migration
......................................................................

[WIP] BZ#855922, fix attribute error during migration

way 1: make the blockDev property read-write, not read-only

Signed-off-by: Peter V. Saveliev <peet at redhat.com>
Change-Id: I81e7c9a74d19c679c4e11c63b4cf854a9d19c26c
---
M vdsm/libvirtvm.py
1 file changed, 8 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/8185/1

diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py
index 7bc68b2..5af86e3 100644
--- a/vdsm/libvirtvm.py
+++ b/vdsm/libvirtvm.py
@@ -1016,14 +1016,13 @@
         self.name = self._makeName()
 
         if self.device in ("cdrom", "floppy"):
-            self._blockDev = False
+            self.blockDev = False
         else:
-            self._blockDev = None
+            self.blockDev = None
 
         self._customize()
 
-    @property
-    def blockDev(self):
+    def _get_blockDev(self):
         if self._blockDev is None:
             try:
                 self._blockDev = utils.isBlockDevice(self.path)
@@ -1032,6 +1031,11 @@
                                "block device", self.path, exc_info=True)
         return self._blockDev
 
+    def _set_blockDev(self, value):
+        self._blockDev = value
+
+    blockDev = property(_get_blockDev, _set_blockDev)
+
     def _customize(self):
         # Customize disk device
         if self.iface == 'virtio':


--
To view, visit http://gerrit.ovirt.org/8185
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I81e7c9a74d19c679c4e11c63b4cf854a9d19c26c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet at redhat.com>


More information about the vdsm-patches mailing list