Change in vdsm[master]: BZ#856167 - Store engine CA cert in enginecacert.pem

danken at redhat.com danken at redhat.com
Mon Sep 24 13:18:36 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#856167 - Store engine CA cert in enginecacert.pem
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

only naming issues.

....................................................
File vdsm_reg/deployUtil.py.in
Line 1468:             ovirtfunctions.ovirt_safe_delete_config(CACERT)
Line 1469:         if os.path.exists(ENGINECACERT):
Line 1470:             ovirtfunctions.ovirt_safe_delete_config(ENGINECACERT)
Line 1471: 
Line 1472: def getRhevmCert(IP, port):
I could use a comment (or a function rename...) telling that here we obtain the certificate for Engine's https communication.

Come to think of it, the CA in ENGINECACERT is misplaced.
Line 1473: 
Line 1474:     dontcare, VDSMCERT, ENGINECACERT = certPaths('')
Line 1475:     RHEVM_CERT_FILE = "/ca.crt"
Line 1476:     rhevmCert = getRemoteFile(str(IP), str(port), RHEVM_CERT_FILE)


Line 1470:             ovirtfunctions.ovirt_safe_delete_config(ENGINECACERT)
Line 1471: 
Line 1472: def getRhevmCert(IP, port):
Line 1473: 
Line 1474:     dontcare, VDSMCERT, ENGINECACERT = certPaths('')
I suppose you dontcare here about VDSMCERT, too.

A more commonplace way to name dontcare is "_".
Line 1475:     RHEVM_CERT_FILE = "/ca.crt"
Line 1476:     rhevmCert = getRemoteFile(str(IP), str(port), RHEVM_CERT_FILE)
Line 1477:     if rhevmCert:
Line 1478:         dirName = os.path.dirname(ENGINECACERT)


--
To view, visit http://gerrit.ovirt.org/8038
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I127bf44cbcde90f7dae26a3bd3127f3eac2ca53c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>


More information about the vdsm-patches mailing list