Change in vdsm[master]: Fix data passing to process when doing async execution

danken at redhat.com danken at redhat.com
Sun Sep 23 18:08:30 UTC 2012


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Fix data passing to process when doing async execution
......................................................................


Fix data passing to process when doing async execution

There is a mistake in the current file where the stream data is being
sent to when using `sync=False` is stdout instead of stdin. This makes
the feature not work.

Further more, I added flush so that the data is sent before the function
returns because it's a bit more intuitive.

Also, add a test to check that this feature works so in the future this
kind of thing wouldn't occur.

Change-Id: Ibe496e74a24721ba00c596d36286bcdafdc20069
Signed-off-by: Saggi Mizrahi <smizrahi at redhat.com>
---
M tests/miscTests.py
M vdsm/storage/misc.py
2 files changed, 10 insertions(+), 1 deletion(-)

Approvals:
  Yeela Kaplan: Looks good to me, but someone else must approve
  Shu Ming: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/8081
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe496e74a24721ba00c596d36286bcdafdc20069
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list