Change in vdsm[master]: Fix data passing to process when doing async execution

ykaplan at redhat.com ykaplan at redhat.com
Sun Sep 23 13:45:21 UTC 2012


Yeela Kaplan has posted comments on this change.

Change subject: Fix data passing to process when doing async execution
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File tests/miscTests.py
Line 355:     def testCommunicate(self):
Line 356:         data = ("The trouble with the world is that the stupid are cocksure "
Line 357:                 "and the intelligent are full of doubt")
Line 358:         p = misc.execCmd(["dd"], data=data, sudo=False, sync=False)
Line 359:         p.stdin.flush()
You should remove flush here as you've added it to execCmd...
Line 360:         p.stdin.close()
Line 361:         self.assertEquals(p.stdout.read(len(data)).strip(), data)
Line 362: 
Line 363: 


--
To view, visit http://gerrit.ovirt.org/8081
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe496e74a24721ba00c596d36286bcdafdc20069
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list