Change in vdsm[master]: [WIP] Add a releaseHostId option to stop the DomainMonitorTh...
fsimonce at redhat.com
fsimonce at redhat.com
Fri Sep 21 14:17:25 UTC 2012
Federico Simoncelli has posted comments on this change.
Change subject: [WIP] Add a releaseHostId option to stop the DomainMonitorThread
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/sp.py
Line 598: finally:
Line 599: self._setUnsafe()
Line 600:
Line 601: self._releaseTemporaryClusterLock(msdUUID)
Line 602: self.stopMonitoringDomains()
Testing this patch I discovered that it introduces a race around here (I didn't have time to dig more into details).
Line 603:
Line 604: return True
Line 605:
Line 606: @unsecured
--
To view, visit http://gerrit.ovirt.org/7581
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I83458fb4146de7e402606916615533da305bd867
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list