Change in vdsm[master]: Add simple text-based console in vdsClient

Xu He Jie xuhj at linux.vnet.ibm.com
Fri Sep 21 05:06:34 UTC 2012


Xu He Jie has posted comments on this change.

Change subject: Add simple text-based console in vdsClient
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm_cli/vdsClient.py
Line 1612: 
Line 1613:     def openVmConsole(self, args):
Line 1614:         protocol = "tls" if self.useSSL else "tcp"
Line 1615:         conn = "qemu+" + protocol + "://" + self.server + "/system"
Line 1616:         p = subprocess.Popen(["virsh", "-c", conn, "console", args[0]])
ShaoHe, you are right, I need add dependence for virsh. This is for human first. We will improve this later.
Line 1617:         p.wait()
Line 1618: 
Line 1619: 
Line 1620: if __name__ == '__main__':


--
To view, visit http://gerrit.ovirt.org/8041
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I368dbcbc2e180161f256f3fb450c344acb6a6c8a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list