Change in vdsm[master]: Add simple text-based console in vdsClient

Xu He Jie xuhj at linux.vnet.ibm.com
Fri Sep 21 02:06:01 UTC 2012


Xu He Jie has posted comments on this change.

Change subject: Add simple text-based console in vdsClient
......................................................................


Patch Set 1: (2 inline comments)

....................................................
Commit Message
Line 8: 
Line 9: Add new command 'openConsole' in vdsClient. This command
Line 10: invoke 'virsh console' directly. This is easy implement for text-based
Line 11: console. It means we can have a vdsm text console right now.
Line 12: We can improve text console in futrue.
Done. Thanks for the review!
Line 13: 
Line 14: Change-Id: I368dbcbc2e180161f256f3fb450c344acb6a6c8a


....................................................
File vdsm_cli/vdsClient.py
Line 122: class service:
Line 123:     def __init__(self):
Line 124:         self.useSSL = False
Line 125:         self.truststore = None
Line 126:         self.server = "0"
In the beginning, I think If it is None, we need another check in openVmConsole. like:
if self.server == None:
     server = "0"
conn = "qemu+" + protocol + "://" + self.server + "/system"

But most of the time server won't be None. We will do_connect first. If we didn't call do_connec firist, the "0" will cover this mistake. 

So None is better. 

Thanks
Line 127: 
Line 128:     def do_connect(self, server, port):
Line 129:         self.server = server
Line 130:         self.s = vdscli.connect(server + ':' + port,


--
To view, visit http://gerrit.ovirt.org/8041
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I368dbcbc2e180161f256f3fb450c344acb6a6c8a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list