Change in vdsm[master]: migrateStatus() progress report

Ryan Harper ryanh at us.ibm.com
Thu Sep 20 20:28:34 UTC 2012


Ryan Harper has posted comments on this change.

Change subject: migrateStatus() progress report
......................................................................


Patch Set 6: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/vm.py
Line 103:         """
Line 104:         Get the status of the migration.
Line 105:         """
Line 106:         try:
Line 107:             # get a libvirt connection
This is a nit pick, but we're not getting a connection, but rather a reference to the VM instance.
Line 108:             libvirtVm = self._connection.lookupByUUID(self._vm.id)
Line 109:             # jobInfo reference: http://libvirt.org/html/libvirt-libvirt.html#virDomainJobInfo
Line 110:             (dataTotal, dataProcessed, dataRemaining) = libvirtVm.jobInfo()[3:6]
Line 111:             # get transfer percentage


--
To view, visit http://gerrit.ovirt.org/6824
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list