Change in vdsm[master]: BZ#844180: Change scsi scan to asynchronous

danken at redhat.com danken at redhat.com
Thu Sep 20 18:47:41 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#844180: Change scsi scan to asynchronous
......................................................................


Patch Set 16: (1 inline comment)

....................................................
File vdsm/storage/iscsi.py
Line 356:     maxTimeout = config.getint('irs', 'scsi_rescan_maximal_timeout')
Line 357:     for hba in glob.glob(SCAN_PATTERN):
Line 358:         cmd = [constants.EXT_DD, 'of=' + hba]
Line 359:         p = misc.execCmd(cmd, sudo=False, sync=False)
Line 360:         p.stdin.write("- - -")
that's saner than adding tipple-dash.txt file. but why not use the recently-fixed "data" argument to execCmd?
Line 361:         p.stdin.flush()
Line 362:         p.stdin.close()
Line 363:         processes.append((hba, p))
Line 364:     if (minTimeout > maxTimeout or minTimeout < 0):


--
To view, visit http://gerrit.ovirt.org/6796
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7665ebaed716f75af4d03ec1b6a9ff9ff5d84853
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list