Change in vdsm[master]: Do not propagate top layer interfaces bootproto to the under...

asegurap at redhat.com asegurap at redhat.com
Thu Sep 20 12:05:05 UTC 2012


Antoni Segura Puimedon has posted comments on this change.

Change subject: Do not propagate top layer interfaces bootproto to the underlying devices.
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 904:         # only on most top device according to following order:
Line 905:         # bridge -> vlan -> bond -> nic
Line 906:         # For lower level devices we should ignore it.
Line 907:         # reset ip, netmask, gateway and bootproto for lower level devices
Line 908:         bridgeBootproto = options.get('bootproto')
It is needed for the asynchronous DHCP ifupping of the bridge interface.
Line 909:         ipaddr = netmask = gateway = options['bootproto'] = None
Line 910: 
Line 911:     # For VLAN we should attach bridge only to the VLAN device
Line 912:     # rather than to underlying NICs or bond


--
To view, visit http://gerrit.ovirt.org/8058
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd308c6db11d8641ecee84817c5f0b9d6e5eaf74
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list