Change in vdsm[master]: Move the lastCheck computation in getRepoStats

fsimonce at redhat.com fsimonce at redhat.com
Thu Sep 20 09:34:58 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: Move the lastCheck computation in getRepoStats
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/sp.py
Line 1370:             res[sdUUID] = {
Line 1371:                     'finish' : st.lastCheck,
Line 1372:                     'result' : {
Line 1373:                         'code'      : code,
Line 1374:                         'lastCheck' : '%.1f' % (now - st.lastCheck),
Yes, because we don't want to issue a syscall each time (knowing in advance that this loop can't take a long time and the "now" value is accurate enough).
Line 1375:                         'delay'     : str(st.readDelay),
Line 1376:                         'valid'     : (st.error is None)
Line 1377:                         },
Line 1378:                     'disktotal' : disktotal,


--
To view, visit http://gerrit.ovirt.org/7993
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58de0c517bc6940f21c7f6506854c9d9735e964b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list