Change in vdsm[master]: Properly propagate pool timeout in file handler

ewoud at kohlvanwijngaarden.nl ewoud at kohlvanwijngaarden.nl
Wed Sep 19 15:07:34 UTC 2012


Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: Properly propagate pool timeout in file handler
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File vdsm/storage/remoteFileHandler.py
Line 184:             # If for some reason the connection drops\gets out of sync we treat
Line 185:             # it as a timeout so we only have one error path
Line 186:             self.log.warn("Problem with handler, treating as timeout",
Line 187:                     exc_info=True)
Line 188:             raise Timeout()
It's re-raising any exception as a timeout. Maybe it would be good to reraise instead of raising as timeout without any stack, but I think that's better in a separate patch.
Line 189: 
Line 190:         res, err = pickle.loads(rawResponse)
Line 191:         if err is not None:
Line 192:             raise err


--
To view, visit http://gerrit.ovirt.org/6671
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie32aa474d3ab9ec455c15415df20b749d54e5658
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list