Change in vdsm[master]: glusterHostsList verb returns local hostname as IP address o...

Shireesh Anjal sanjal at redhat.com
Tue Sep 18 13:42:48 UTC 2012


Shireesh Anjal has posted comments on this change.

Change subject: glusterHostsList verb returns local hostname as IP address or FQDN
......................................................................


Patch Set 1: (1 inline comment)

Detailed response to Dan's question in-line.

....................................................
Commit Message
Line 3: AuthorDate: 2012-09-09 08:32:53 +0530
Line 4: Commit:     Bala.FA <barumuga at redhat.com>
Line 5: CommitDate: 2012-09-09 08:32:53 +0530
Line 6: 
Line 7: glusterHostsList verb returns local hostname as IP address or FQDN
Let me try and elaborate on what Bala means.

The verb glusterHostsList executes the 'gluster peer status' command to fetch list of servers of the gluster cluster. However the output of this command doesn't include the server on which the command is being executed. So the verb then appends the list given by gluster with the current server name.

There are two options - either append the hostname or one of the ip addresses. The problem with hostname is that what's saved in engine db in the host_name field is not necessarily the actual hostname of the host, but whatever user entered while adding the host, which could be ip address also.

Hence we can't rely on the hostname, particularly because we need to compare the list returned by the glusterHostsList verb with the list of hosts present in engine DB to identify if something has changed because of direct cli operations from the gluster cli. Hence Bala is changing this verb to send back an ip address of the current server, instead of hostname. engine db contains all ip addresses of the server, and hence ip address can be used for comparisons.

Am I making any sense?
Line 8: 
Line 9: Change-Id: I24d2b4d27107d208672b1d3df96dd7759d2288c5


--
To view, visit http://gerrit.ovirt.org/7857
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24d2b4d27107d208672b1d3df96dd7759d2288c5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>


More information about the vdsm-patches mailing list