Change in vdsm[master]: add and use hypervisor autodetection in bootstrap.

shuming at linux.vnet.ibm.com shuming at linux.vnet.ibm.com
Tue Sep 18 01:58:23 UTC 2012


Shu Ming has posted comments on this change.

Change subject: add and use hypervisor autodetection in bootstrap.
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm_reg/deployUtil.py.in
Line 1346: 
Line 1347: def findHypervisor():
Line 1348:     name = ''
Line 1349:     hid = cpuHypervisorID()
Line 1350:     if hid == 'VMwareVMware':
The code will be more compatible if "'VMware' in hid:" is used instead of hard equation.  The same as if conditions below.
Line 1351:         name = 'vmware'
Line 1352:     elif hid == 'Microsoft Hv':
Line 1353:         name = 'hyperv'
Line 1354:     elif hid == 'XenVMMXenVMM':


--
To view, visit http://gerrit.ovirt.org/7657
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79f4ab08b838bd75af5d4c26f98923fca0d65d8e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at gmail.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list