Change in vdsm[master]: converting some more RH strings to oVirt

danken at redhat.com danken at redhat.com
Mon Sep 17 19:19:00 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: converting some more RH strings to oVirt
......................................................................


Patch Set 6: I would prefer that you didn't submit this

(1 inline comment)

minor comment about names.

....................................................
File vdsm/constants.py.in
Line 21: # Description:    Constants definitions for vdsm and utilities.
Line 22: 
Line 23: import os
Line 24: 
Line 25: # SMBIOS manufacturer
if you need this comment, it means that the variable name is not good enough..

how about

  SMBIOS_MANUFACTURER, SMBIOS_OSNAME ?
Line 26: MANUFACTURER = '@MANUFACTURER@'
Line 27: 
Line 28: # SMBIOS name
Line 29: OSNAME = '@OSNAME@'


--
To view, visit http://gerrit.ovirt.org/7841
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d9a401e93cedc8e07b3f3e14ad523d00e9f0f94
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>


More information about the vdsm-patches mailing list