Change in vdsm[master]: faqemu: remove the fake /dev/kvm after vdsmd stops

danken at redhat.com danken at redhat.com
Sun Sep 16 08:38:11 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: faqemu: remove the fake /dev/kvm after vdsmd stops
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm_hooks/faqemu/after_vdsm_stop.py
Line 19: # Refer to the README and COPYING files for full details of the license
Line 20: #
Line 21: 
Line 22: import os
Line 23: import os.path
didn't you say you will drop this os.path?
Line 24: 
Line 25: if os.path.isfile('/dev/kvm'):
Line 26:     try:
Line 27:         os.unlink('/dev/kvm')


Line 21: 
Line 22: import os
Line 23: import os.path
Line 24: 
Line 25: if os.path.isfile('/dev/kvm'):
isfile is not really needed either.
Line 26:     try:
Line 27:         os.unlink('/dev/kvm')
Line 28:     except OSError as e:
Line 29:         if e.errno != os.errno.ENOENT:


--
To view, visit http://gerrit.ovirt.org/7885
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c1183acf90cd32444b1c26fa20aa843e4a0556d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list