Change in vdsm[master]: '0' is a valid master version

shuming at linux.vnet.ibm.com shuming at linux.vnet.ibm.com
Thu Sep 13 00:48:25 UTC 2012


Shu Ming has posted comments on this change.

Change subject: '0' is a valid master version
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 848:                 pool.getMasterDomain(msdUUID=msdUUID, masterVersion=masterVersion)
Line 849:                 return
Line 850: 
Line 851:             pool = sp.StoragePool(spUUID, self.taskMng)
Line 852:             if not hostID or not scsiKey or not msdUUID or (masterVersion == None):
Adam, masterversion = 0 here will make "not masterVersion" to be true.  And the pool.getPoolParams() will be called, tough the temporary pool file is not initialized yet.
Line 853:                 hostID, scsiKey, msdUUID, masterVersion = pool.getPoolParams()
Line 854:             res = pool.connect(hostID, scsiKey, msdUUID, masterVersion)
Line 855:             if res:
Line 856:                 self.pools[spUUID] = pool


--
To view, visit http://gerrit.ovirt.org/7948
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I736d917bfa7d3a5ac59cddcaf1a18846f53d85b0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list