Change in vdsm[master]: Modify getOSVersion to use python 'platform' module

danken at redhat.com danken at redhat.com
Wed Sep 12 19:49:33 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Modify getOSVersion to use python 'platform' module
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm_reg/deployUtil.py.in
Line 448:     # platform.linux_distribution returns a tuple (distname, version, id) or
Line 449:     # default as given in args in case of any failure
Line 450:     osVer = platform.linux_distribution(distname='',version='Unknown OS')
Line 451:     logging.debug("OS Release Ver = %s", osVer[1])
Line 452:     return osVer[1]
the string'ed int output of this is used only by bootstrap script itself.

afaikt, the output of this function is conserved by this patch.
Line 453: 
Line 454: def getKernelVR():
Line 455:     """Return current kernel version and release."""
Line 456: 


--
To view, visit http://gerrit.ovirt.org/7930
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia58284ce75dc6d09f0302181ea35ed3817dd861d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip at in.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Pradipta Banerjee <bpradip at in.ibm.com>


More information about the vdsm-patches mailing list