Change in vdsm[master]: vdsm-reg-setup: get hostname with gethostname()

Ryan Harper ryanh at us.ibm.com
Wed Sep 12 06:00:02 UTC 2012


Ryan Harper has posted comments on this change.

Change subject: vdsm-reg-setup: get hostname with gethostname()
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

It wasn't immediately clear why using gethostname() fixed the issue.  After reading python socket docs on getfqdn() it seems like we were relying on fqdn fallback to getting the hostname.

Might be worth a mention in the commit message.

--
To view, visit http://gerrit.ovirt.org/7939
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38ec4c570d7f250d64e62e01b91cd2828780c45b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list