Change in vdsm[master]: vdsm bootstrap changes for kvm on ppc64 support

danken at redhat.com danken at redhat.com
Tue Sep 11 09:37:48 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm bootstrap changes for kvm on ppc64 support
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File vdsm_reg/deployUtil.py.in
Line 37: import httplib
Line 38: import glob
Line 39: import imp
Line 40: from optparse import OptionParser
Line 41: import platform
I like code reuse. Thanks!
However, please split this change into a separate patch. it is not ppc64-specific. Splitting to small topics my review.
Line 42: 
Line 43: try:
Line 44:     from ovirtnode import ovirtfunctions
Line 45: except ImportError:


--
To view, visit http://gerrit.ovirt.org/7072
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06ca5dc3adba6183657afed778f999715ee332e0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip at in.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Pradipta Banerjee <bpradip at in.ibm.com>


More information about the vdsm-patches mailing list