Change in vdsm[master]: Support for GLUSTERFS_DOMAIN
danken at redhat.com
danken at redhat.com
Tue Sep 11 08:54:39 UTC 2012
Dan Kenigsberg has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/blockSD.py
Line 469: t = time.time()
Line 470: misc.readfile(lvm.lvPath(self.sdUUID, sd.METADATA), 4096)
Line 471: return time.time() - t
Line 472:
Line 473:
this change does not seems strictly gluster-related. Would you split it into a separate patch, explaining its logic and correctness?
Line 474: def getVolumeClass(self):
Line 475: """
Line 476: Return a type specific volume generator object
Line 477: """
....................................................
File vdsm/storage/glusterVolume.py
Line 20: # Volume transport to Libvirt transport mapping
Line 21: VOLUME_TRANS_MAP = {'TCP': 'socket', 'RDMA': 'rdma'}
Line 22:
Line 23: # Extract the volume's transport using gluster cli
Line 24: # FIXME: How to handle the vdsm-gluster rpm dependency ?
The thing is that I would not like vdsm proper to have a hard requirement for gluster. We could move the gluster/cli.py "binding" into vdsm, but we must allow, and gracefully fail, in case gluster is not found during runtime.
A better approach would have been to make a modular framework for storage domains. But I do not have a mental blueprint for this...
Line 25: svdsmProxy = svdsm.getProxy()
Line 26: volInfo = svdsmProxy.glusterVolumeInfo(volname)
Line 27: volTrans = VOLUME_TRANS_MAP[volInfo[volname]['transportType'][0]]
Line 28:
--
To view, visit http://gerrit.ovirt.org/6856
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list