Change in vdsm[master]: supervdsmServer is down after failed operation

ybronhei at redhat.com ybronhei at redhat.com
Tue Sep 11 07:45:44 UTC 2012


Yaniv Bronhaim has posted comments on this change.

Change subject: supervdsmServer is down after failed operation
......................................................................


Patch Set 3:

In general every method in _SuperVdsm can throw exception that we don't handle. As I see we have 2 options:

1. In _SuperVdsm we can catch every exception, report it and treat it specifically (In each method provides by superVdsmServer proxy) - but this can cause crashes if we'll add method to superVdsmServer without exceptions handling.. 

2. We can add general activity, as it is now, and handle the exception in ProxyCaller by report it, reset superVdsmServer and then wait for the user to active the action again after distinguish why it didn't work (as in this patch). Or we can call the method again and pray it will work. And than, if it still doesn't, we can die (as before this patch)..

We can work specifically about option1 and check every supervdsmServer method and its exception handling, but this patch comes to solve non-handled cases.

And by the way, if we have different exception than IOError, socket.error, AuthenticationError - supervdsmServer just dies quietly

--
To view, visit http://gerrit.ovirt.org/7901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idad4a622b82259b777851d1b0c1b37ec8da2b01e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list