Change in vdsm[master]: caps.osversion: use @memoized instead of reimplementing it

danken at redhat.com danken at redhat.com
Tue Sep 11 07:06:25 UTC 2012


Dan Kenigsberg has uploaded a new change for review.

Change subject: caps.osversion: use @memoized instead of reimplementing it
......................................................................

caps.osversion: use @memoized instead of reimplementing it

Change-Id: I81e378b1d4b94e9677f7aa3221c8bed1d39406cc
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/caps.py
1 file changed, 2 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/7918/1

diff --git a/vdsm/caps.py b/vdsm/caps.py
index f1641ff..b2ca9b4 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -194,14 +194,8 @@
         return OSName.UNKNOWN
 
 
-__osversion = None
-
-
+ at utils.memoized
 def osversion():
-    global __osversion
-    if __osversion is not None:
-        return __osversion
-
     version = release = ''
 
     osname = getos()
@@ -224,8 +218,7 @@
     except:
         logging.error('failed to find version/release', exc_info=True)
 
-    __osversion = dict(release=release, version=version, name=osname)
-    return __osversion
+    return dict(release=release, version=version, name=osname)
 
 
 def get():


--
To view, visit http://gerrit.ovirt.org/7918
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I81e378b1d4b94e9677f7aa3221c8bed1d39406cc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list