Change in vdsm[master]: vdsm: replace rpm commandline with rpm-python api in caps.py

danken at redhat.com danken at redhat.com
Tue Sep 11 06:58:43 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: replace rpm commandline with rpm-python api in caps.py
......................................................................


Patch Set 2: Fails; I would prefer that you didn't submit this

(1 inline comment)

Please verify your change.

....................................................
File vdsm/caps.py
Line 313: 
Line 314:         try:
Line 315:             ts = rpm.TransactionSet()
Line 316:             for pkg in KEY_PACKAGES:
Line 317:                 for r in ts.dbMatch('name', pkg):
"r" is already used for something completely different...
Line 318:                     v = r['version']
Line 319:                     r = r['release']
Line 320:                     t = r['buildtime']
Line 321:                 pkgs[pkg] = dict(version=v, release=r, buildtime=t)


--
To view, visit http://gerrit.ovirt.org/7856
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7745028553d7af54fab19fa0ef4402357f36ebb9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jarod.w <work.iec23801 at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jarod.w <work.iec23801 at gmail.com>


More information about the vdsm-patches mailing list