Change in vdsm[master]: vdsm bootstrap changes for kvm on ppc64 support

bpradip at in.ibm.com bpradip at in.ibm.com
Mon Sep 10 16:27:00 UTC 2012


Pradipta Banerjee has posted comments on this change.

Change subject: vdsm bootstrap changes for kvm on ppc64 support
......................................................................


Patch Set 6: (3 inline comments)

....................................................
File vds_bootstrap/vds_bootstrap.py
Line 300:                 self.res = "Intel"
Line 301:             elif "AuthenticAMD" == deployUtil.cpuVendorID():
Line 302:                 self.res = "AMD"
Line 303:             elif "IBM_POWER" == deployUtil.cpuVendorID():
Line 304:                 self.res = "IBM"
Should I use 'AMD' as the default like the orig code? Please advise
Line 305: 
Line 306:         if self.vt_svm is None:
Line 307:             self.vt_svm = "NA"
Line 308: 


....................................................
File vdsm_reg/deployUtil.py.in
Line 321: 
Line 322:         if ret == 0 and "Not" not in out: #Avoid error string- 'Not Settable' or 'Not Present'
Line 323:             strReturn = out.replace ("\n", "")
Line 324:     elif getPlatformArch() == "ppc64":
Line 325:             if os.path.exists('/proc/device-tree/system-id'):
If not, it'll just return "None".
Line 326:                 strReturn = file('/proc/device-tree/system-id').readline().replace(",","")
Line 327:     else:
Line 328:         logging.error("getMachineUUID: Could not find machine's UUID.")
Line 329: 


Line 322:         if ret == 0 and "Not" not in out: #Avoid error string- 'Not Settable' or 'Not Present'
Line 323:             strReturn = out.replace ("\n", "")
Line 324:     elif getPlatformArch() == "ppc64":
Line 325:             if os.path.exists('/proc/device-tree/system-id'):
Line 326:                 strReturn = file('/proc/device-tree/system-id').readline().replace(",","")
The o/p of /proc/device-tree/system-id will be something like "IBM,03061C14A"
which will be converted to "IBM03061C14A"
Line 327:     else:
Line 328:         logging.error("getMachineUUID: Could not find machine's UUID.")
Line 329: 
Line 330:     return strReturn


--
To view, visit http://gerrit.ovirt.org/7072
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06ca5dc3adba6183657afed778f999715ee332e0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip at in.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Pradipta Banerjee <bpradip at in.ibm.com>


More information about the vdsm-patches mailing list