Change in vdsm[master]: Fix the check to convert block domains V0 to tag metadata

abaron at redhat.com abaron at redhat.com
Mon Sep 10 13:06:47 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: Fix the check to convert block domains V0 to tag metadata
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/storage/sp.py
Line 1027:                                 domain.getRealDomain(), isMsd, targetFormat)
Line 1028:         finally:
Line 1029:             # For safety we remove the domain from the cache also if the
Line 1030:             # conversion supposedly failed.
Line 1031:             sdCache.manuallyRemoveDomain(sdUUID)
probably could use a produce here
Line 1032: 
Line 1033:     @unsecured
Line 1034:     def getFormat(self):
Line 1035:         return str(self.getVersion())


--
To view, visit http://gerrit.ovirt.org/7654
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic034c0bf90ce3ecd82dad2f5879838bb1445e7e2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list