Change in vdsm[master]: report idle time for multiple vcpus

asegurap at redhat.com asegurap at redhat.com
Mon Sep 10 09:32:57 UTC 2012


Antoni Segura Puimedon has posted comments on this change.

Change subject: report idle time for multiple vcpus
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 163:             netSamples[nic.name] = self._vm._dom.interfaceStats(nic.name)
Line 164:         return netSamples
Line 165: 
Line 166:     def _getCpuStats(self, stats):
Line 167:         nrOfCpus = self._vm._dom._dom.info()[3]
Since the libvirt API is quite cryptic and info does not convey what information we are getting, I would propose to change the variable name into something like in libvirt webpage:
nbVirtCPU.
Line 168:         stats['cpuSys'] = 0.0
Line 169:         sInfo, eInfo, sampleInterval = self.sampleCpu.getStats()
Line 170: 
Line 171:         try:


--
To view, visit http://gerrit.ovirt.org/7892
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>


More information about the vdsm-patches mailing list