Change in vdsm[master]: DomainMonitor shouldn't releaseHostId if the domain is missi...

abaron at redhat.com abaron at redhat.com
Sun Sep 9 22:11:13 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: DomainMonitor shouldn't releaseHostId if the domain is missing
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/domainMonitor.py
Line 150:         self.log.debug("Stopping domain monitor for %s", self.sdUUID)
Line 151: 
Line 152:         # If this is an ISO domain we didn't acquire the host id and releasing
Line 153:         # it is superfluous.
Line 154:         if self.domain and not self.isIsoDomain:
what's preventing self.domain from changing to None between this 'if' and releasehostId?
Line 155:             try:
Line 156:                 self.domain.releaseHostId(self.hostId, unused=True)
Line 157:             except:
Line 158:                 self.log.debug("Unable to release the host id %s for domain "


--
To view, visit http://gerrit.ovirt.org/7833
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b2d97f95d682ea00079cee0c0587243ed56651c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list