Change in vdsm[master]: vdsm-tool/load_needed_modules: fix creation of legacy bonds

danken at redhat.com danken at redhat.com
Sun Sep 9 17:51:58 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm-tool/load_needed_modules: fix creation of legacy bonds
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm-tool/load_needed_modules.py.in
Line 47:     existing = set(file(MASTER_FILE).read().split())
Line 48:     with open(MASTER_FILE, 'w') as f:
Line 49:         for bond in REQUIRED - existing:
Line 50:             f.write('+%s\n' % bond)
Line 51: 
what would you do with it when you caught it? is it really better than Python's defaults?
Line 52: 
Line 53: @expose('load-needed-modules')
Line 54: def load_needed_modules():
Line 55:     """


--
To view, visit http://gerrit.ovirt.org/7879
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82dd48d52541b6d35606fd8358cd98cd9f46fed5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list