Change in vdsm[master]: Add uploadIso API call for pushing ISOs into an active iso_d...
Ryan Harper
ryanh at us.ibm.com
Fri Sep 7 19:54:14 UTC 2012
Ryan Harper has posted comments on this change.
Change subject: Add uploadIso API call for pushing ISOs into an active iso_domain via pool
......................................................................
Patch Set 1: Verified
Verified on F16 vdsm deployment via a LOCALFS storage domain for data and isos.
localonly.py script does:
- creates /var/lib/vdsm/{images|isos}
- chown -R to vdsm.kvm
- create storage domain type data on /var/lib/vdsm/images
- create storage domain type iso on /var/lib/vdsm/isos
- create storage pool with previous two domains
- enables SPM on data domain
- activates iso domain
create a second storage domain, data, LOCALFS
define a pool with second storage data domain with no isodomain
Run the following scenarios via vdsClient uploadIso
# expected pass
expect_pass upload_iso $POOL1 $URL
expect_pass upload_iso $POOL1 $FILE
expect_pass upload_iso $POOL1 $URL wget
expect_pass upload_iso $POOL1 $FILE rsync
# expected fail
## invalid method
expect_fail upload_iso $POOL1 $FILE wark
## mismatch method
expect_fail upload_iso $POOL1 $URL rsync
expect_fail upload_iso $POOL1 $FILE wget
## missing pool
expect_fail upload_iso $FILE
## inactive pool
expect_fail upload_iso $POOL2 $URL
expect_fail upload_iso $POOL2 $FILE
expect_fail upload_iso $POOL2 $URL wget
expect_fail upload_iso $POOL2 $FILE rsync
## active pool no iso_domain
echo "Activating Pool without iso domain ..."
./activate_storage_pool.py $POOL2 &>/dev/null
expect_fail upload_iso $POOL2 $URL
expect_fail upload_iso $POOL2 $FILE
expect_fail upload_iso $POOL2 $URL wget
expect_fail upload_iso $POOL2 $FILE rsync
Output of tests:
[root at ichigo-dom242 vdsm-helpers]# bash ./test_uploadiso.sh setup
Preparing localhost for testing
Host is ready; POOL1=0b245327-baeb-4455-bf31-d1638499aa1a POOL2=79b40803-d39f-44de-a8df-5f3358cdc286
Expect PASS: upload_iso 0b245327-baeb-4455-bf31-d1638499aa1a http://ltcphx.austin.ibm.com/isos/winparavirt.iso...OK
Expect PASS: upload_iso 0b245327-baeb-4455-bf31-d1638499aa1a /tmp/ttylinux-i686-14.0.iso...OK
Expect PASS: upload_iso 0b245327-baeb-4455-bf31-d1638499aa1a http://ltcphx.austin.ibm.com/isos/winparavirt.iso wget...OK
Expect PASS: upload_iso 0b245327-baeb-4455-bf31-d1638499aa1a /tmp/ttylinux-i686-14.0.iso rsync...OK
Expect FAIL: upload_iso 0b245327-baeb-4455-bf31-d1638499aa1a /tmp/ttylinux-i686-14.0.iso wark...OK
Expect FAIL: upload_iso 0b245327-baeb-4455-bf31-d1638499aa1a http://ltcphx.austin.ibm.com/isos/winparavirt.iso rsync...OK
Expect FAIL: upload_iso 0b245327-baeb-4455-bf31-d1638499aa1a /tmp/ttylinux-i686-14.0.iso wget...OK
Expect FAIL: upload_iso /tmp/ttylinux-i686-14.0.iso...OK
Expect FAIL: upload_iso 79b40803-d39f-44de-a8df-5f3358cdc286 http://ltcphx.austin.ibm.com/isos/winparavirt.iso...OK
Expect FAIL: upload_iso 79b40803-d39f-44de-a8df-5f3358cdc286 /tmp/ttylinux-i686-14.0.iso...OK
Expect FAIL: upload_iso 79b40803-d39f-44de-a8df-5f3358cdc286 http://ltcphx.austin.ibm.com/isos/winparavirt.iso wget...OK
Expect FAIL: upload_iso 79b40803-d39f-44de-a8df-5f3358cdc286 /tmp/ttylinux-i686-14.0.iso rsync...OK
Activating Pool without iso domain ...
Expect FAIL: upload_iso 79b40803-d39f-44de-a8df-5f3358cdc286 http://ltcphx.austin.ibm.com/isos/winparavirt.iso...OK
Expect FAIL: upload_iso 79b40803-d39f-44de-a8df-5f3358cdc286 /tmp/ttylinux-i686-14.0.iso...OK
Expect FAIL: upload_iso 79b40803-d39f-44de-a8df-5f3358cdc286 http://ltcphx.austin.ibm.com/isos/winparavirt.iso wget...OK
Expect FAIL: upload_iso 79b40803-d39f-44de-a8df-5f3358cdc286 /tmp/ttylinux-i686-14.0.iso rsync...OK
Total tests=16 Passes=16 Fails=0
--
To view, visit http://gerrit.ovirt.org/7849
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id78e46513c38789d08e63a38026b28bebb9a2b12
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
More information about the vdsm-patches
mailing list