Change in vdsm[master]: Support for GLUSTERFS_DOMAIN

deepakcs at linux.vnet.ibm.com deepakcs at linux.vnet.ibm.com
Fri Sep 7 08:46:16 UTC 2012


Deepak C Shetty has posted comments on this change.

Change subject: Support for GLUSTERFS_DOMAIN
......................................................................


Patch Set 6: (2 inline comments)

....................................................
File vdsm/storage/glusterVolume.py
Line 21:         VOLUME_TRANS_MAP = {'TCP': 'socket', 'RDMA': 'rdma'}
Line 22: 
Line 23:         # Extract the volume's transport using gluster cli
Line 24:         svdsmProxy = svdsm.getProxy()
Line 25:         volInfo = svdsmProxy.glusterVolumeInfo(volname)
As discussed on IRC, i will post the next patch w/o considering this.
There are packaging issues that need to be resolved which fsimonce prefered to discuss over the next patch.
Line 26:         volTrans = VOLUME_TRANS_MAP[volInfo[volname]['transportType'][0]]
Line 27: 
Line 28:         # Use default port
Line 29:         volPort = "0"


....................................................
File vdsm/storage/nfsSD.py
Line 121:     def getVolumeClass(self):
Line 122:         """
Line 123:         Return a type specific volume generator object
Line 124:         """
Line 125:         if self.getType() == sd.GLUSTERFS_DOMAIN:
Done.
This involved creating new domain, connection classes and changes in cache module to be able to find this domain.
Line 126:             return glusterVolume.GlusterVolume
Line 127:         else:
Line 128:             return fileSD.FileStorageDomain.getVolumeClass(self)
Line 129: 


--
To view, visit http://gerrit.ovirt.org/6856
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list