Change in vdsm[master]: build: Use correct equality operator for /bin/test

danken at redhat.com danken at redhat.com
Thu Sep 6 21:30:45 UTC 2012


Dan Kenigsberg has submitted this change and it was merged.

Change subject: build: Use correct equality operator for /bin/test
......................................................................


build: Use correct equality operator for /bin/test

According to the man page for 'test', the correct token to use for string
equality is '=', not '=='.  '==' works for the bash builtin version but we
should not depend on it (especially since the pkg-version shebang calls for
/bin/sh).  This fixes the build on my Ubuntu system.

Change-Id: I26c317392a55881f96cb4859db822ecd28cc1a65
Signed-off-by: Adam Litke <agl at us.ibm.com>
---
M build-aux/pkg-version
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Adam Litke: Verified
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7834
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I26c317392a55881f96cb4859db822ecd28cc1a65
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>


More information about the vdsm-patches mailing list