Change in vdsm[master]: BZ#844180: Change scsi scan to asynchronous

danken at redhat.com danken at redhat.com
Thu Sep 6 06:47:29 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#844180: Change scsi scan to asynchronous
......................................................................


Patch Set 13: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/storage/iscsi.py
Line 354:     processes = []
Line 355:     minTimeout = config.getint('irs', 'scsi_rescan_minimal_timeout')
Line 356:     maxTimeout = config.getint('irs', 'scsi_rescan_maximal_timeout')
Line 357:     for hba in glob.glob(SCAN_PATTERN):
Line 358:         cmd = ['echo', '- - -', '|', '/bin/dd of=' + hba]
Yeela, would you please elaborate how you have verified this patch? To me it seems that the process you create is echoing the string

 "- - - | /bin/dd of=hba"

to standard output, and immediately exits.

On a side note, we have constants.EXT_DD.
Line 359:         processes.append((hba, misc.execCmd(cmd, sudo=False, sync=False)))
Line 360:     if (minTimeout > maxTimeout or minTimeout < 0):
Line 361:         minTimeout = 2
Line 362:         maxTimeout = 30


Line 357:     for hba in glob.glob(SCAN_PATTERN):
Line 358:         cmd = ['echo', '- - -', '|', '/bin/dd of=' + hba]
Line 359:         processes.append((hba, misc.execCmd(cmd, sudo=False, sync=False)))
Line 360:     if (minTimeout > maxTimeout or minTimeout < 0):
Line 361:         minTimeout = 2
I'd appreciate a commit message explanation on why minTimeout is useful. (I really do not understand. Replacing two sleeps of 1 second with one sleep of 2 seconds does not seem very important to me)
Line 362:         maxTimeout = 30
Line 363:         log.warning("One of the following configuration arguments has an ",
Line 364:                     "illegal value: scsi_rescan_minimal_timeout or ",
Line 365:                     "scsi_rescan_maximal_timeout. Set to %s and %s seconds ",


--
To view, visit http://gerrit.ovirt.org/6796
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7665ebaed716f75af4d03ec1b6a9ff9ff5d84853
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list