Change in vdsm[master]: Move fencing logic out of API.py

agl at us.ibm.com agl at us.ibm.com
Wed Sep 5 20:30:48 UTC 2012


Adam Litke has posted comments on this change.

Change subject: Move fencing logic out of API.py
......................................................................


Patch Set 7: (1 inline comment)

It would be helpful if you would amend your commit message to let us reviewers know what has changed since the previous version.

....................................................
File vdsm_api/vdsmapi-schema.json
Line 305: #
Line 306: # Since: 4.10.0
Line 307: ##
Line 308: {'command': {'class': 'Global', 'name': 'fenceNode'},
Line 309:  'data': {'addr': 'str', 'bladePort': 'int', 'agent': 'str', 'username': 'str',
I think Dan said he wanted 'bladePort' to be a string because depending on the type of fence agent, the port may not actually be a number.
Line 310:           'password': 'str', 'action': 'FenceNodeAction', '*secure': 'bool',
Line 311:           '*options': 'str'},
Line 312:  'returns': {'*power': 'FenceNodePowerStatus'}}
Line 313: 


--
To view, visit http://gerrit.ovirt.org/7190
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I944c6548a42612f705a410fb4290215451bca035
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list