Change in vdsm[master]: Fix the check to convert block domains V0 to tag metadata

fsimonce at redhat.com fsimonce at redhat.com
Wed Sep 5 17:10:10 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: Fix the check to convert block domains V0 to tag metadata
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/storage/imageRepository/formatConverter.py
Line 173:         log.debug("Finalizing the storage domain upgrade from version %s to "
Line 174:                   "version %s for domain %s", currentVersion, targetVersion,
Line 175:                   domain.sdUUID)
Line 176: 
Line 177:         if (currentVersion not in blockSD.VERS_METADATA_TAG
yes it does (blockSD.py:89):

 VERS_METADATA_TAG = (2, 3)

I don't understand your question. Maybe you didn't notice that it's a negative test ("not in").
Line 178:                         and domain.getStorageType() in sd.BLOCK_DOMAIN_TYPES):
Line 179:             __convertDomainMetadataToTags(domain, targetVersion)
Line 180:         else:
Line 181:             domain.setMetaParam(sd.DMDK_VERSION, targetVersion)


--
To view, visit http://gerrit.ovirt.org/7654
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic034c0bf90ce3ecd82dad2f5879838bb1445e7e2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list