Change in vdsm[master]: Fix onDomainConnectivityStateChange in DomainMonitorThread

fsimonce at redhat.com fsimonce at redhat.com
Wed Sep 5 16:47:56 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: Fix onDomainConnectivityStateChange in DomainMonitorThread
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/domainMonitor.py
Line 78:     def startMonitoring(self, sdUUID, hostId):
Line 79:         if sdUUID in self._domains:
Line 80:             return
Line 81: 
Line 82:         domainThread = DomainMonitorThread(self, sdUUID,
I'm not super thrilled by this circular dependency.
Line 83:                                            hostId, self._interval)
Line 84:         domainThread.start()
Line 85:         # The domain should be added only after it succesfully started
Line 86:         self._domains[sdUUID] = domainThread


--
To view, visit http://gerrit.ovirt.org/7772
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3b7e7c788b54726a3c820f4f2180884c74d93ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list