Change in vdsm[master]: Asynchronous LVM bootstrap on vdsm start

danken at redhat.com danken at redhat.com
Mon Sep 3 15:17:24 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Asynchronous LVM bootstrap on vdsm start
......................................................................


Patch Set 1: (1 inline comment)

....................................................
Commit Message
Line 7: Asynchronous LVM bootstrap on vdsm start
Line 8: 
Line 9: The lvm bootstrap might take a long time if one or more block device is
Line 10: unreachable. Moving the bootstrap in the storageRefresh thread speeds up
Line 11: the vdsm initialization and its responsiveness.
would you add a few words why it is fine to live _lvminfo uninitilized for an undefine period of time? what if lvm commands arrive after HSM.__init__, but before _lvminfo.bootstrap finishes?
Line 12: 
Line 13: Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=752470
Line 14: Signed-off-by: Federico Simoncelli <fsimonce at redhat.com>


--
To view, visit http://gerrit.ovirt.org/7566
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cbf1b8880cf2fb38f9de008f884fc0a2b92e004
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Rami Vaknin <rvaknin.redhat.com at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list