Change in vdsm[master]: Add local storage xmlrpc functional test

ybronhei at redhat.com ybronhei at redhat.com
Mon Sep 3 09:56:31 UTC 2012


Yaniv Bronhaim has posted comments on this change.

Change subject: Add local storage xmlrpc functional test
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File tests/functional/xmlrpcTests.py
Line 185:         except Exception:
Line 186:             self._cleanupStorage(rollback)
Line 187:             raise
Line 188: 
Line 189:     @testValidation.ValidateRunningAsRoot
This attribute doesn't work.. I ran it not as Root and it tried to run this test anyway
Line 190:     def testLocalStorage(self):
Line 191:         storageHandle = self._setupStorage()


--
To view, visit http://gerrit.ovirt.org/5860
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e2e80fa88d66d9bc1a4ba855e2df51ba8165e0a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list